Ways to practice electric guitar?

I try to learn a song or 2 a day then I take time to to learn memorize every note on the fret board a day I count them down E1 A1 D1 G1 B1 e1 then I move down E2 A2 D2 G2 B2 e2 and so on for like 20 mins then I just screw around with for an hour. Is that goo enough or are there other ways.